Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y/fix your profile layout #1684

Merged
merged 16 commits into from
Oct 10, 2023
Merged

A11y/fix your profile layout #1684

merged 16 commits into from
Oct 10, 2023

Conversation

andrewleith
Copy link
Member

Summary | Résumé

This PR updates the user profile page to remove the table layout and use flexbox instead.

It also adds 2 a11y features to make navigating this page a little easier:

  1. Adds tab stops on the informational part to make tabbing through the page an option
  2. Adds hidden text on the link to inform the user which setting they would change (rather than just saying "change" for every setting)

Before

image

After

image

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

@andrewleith andrewleith marked this pull request as ready for review October 3, 2023 13:13
@@ -175,6 +175,7 @@ jobs:
CYPRESS_BASE_URL: ${{needs.deploy-test-admin.outputs.LAMBDA_URL}}
with:
record: false
config: "video=false,screenshotOnRunFailure=false"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has nothing to do with this PR but I slipped it in anyway. It makes the cypress tests run much faster by disabling videos and screenshots, which weren't actually working anyway. In a future PR we could make the screenshots and recordings available.

Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!
One suggestion that might be out of scope for this PR is changing the way we display the phone numbers on this page. Without dashes between the phone number parts screen readers will read 6131234567 as six billion one hundred thirty one million..... With dashes it is read more naturally.

Copy link
Contributor

@amazingphilippe amazingphilippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to "wrap" this up:

  1. Lets allow the "Change" link to wrap on the smallest breakpoints. I'd say let's use something like flex-wrap sm:flex-no-wrap. This will give a chance for more content to fit on the smallest screen, and follows a similar pattern we have on the team management screen.
  2. Lets also keep the base font size. The small grey and blue text can be hard to read.

Some design doc for the final layout in Figma

@andrewleith
Copy link
Member Author

A few changes to "wrap" this up:

  1. Lets allow the "Change" link to wrap on the smallest breakpoints. I'd say let's use something like flex-wrap sm:flex-no-wrap. This will give a chance for more content to fit on the smallest screen, and follows a similar pattern we have on the team management screen.
  2. Lets also keep the base font size. The small grey and blue text can be hard to read.

Some design doc for the final layout in Figma

All set! Please re-review.

Copy link
Contributor

@amazingphilippe amazingphilippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewleith andrewleith merged commit 6eed766 into main Oct 10, 2023
@andrewleith andrewleith deleted the a11y/fix-your-profile-layout branch October 10, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants