send freshdesk api #1896
Merged
send freshdesk api #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://ctheo5oqmgd7q5wcypxrkyvevi0qcynm.lambda-url.ca-central-1.on.aws/ |
andrewleith
requested changes
Jul 18, 2024
app/main/views/templates.py
Outdated
Comment on lines
940
to
958
|
|
||
| # Send the information in form's template_category_other field to Freshdesk | ||
| # This code path is a little complex - We do not want to raise an error if the request to Freshdesk fails, only if template creation fails | ||
|
|
||
| if form.template_category_other.data: | ||
| is_english = get_current_locale(current_app) == "en" | ||
| try: | ||
| current_user.send_new_template_category_request( | ||
| current_user.id, | ||
| current_service.id, | ||
| form.template_category_other.data if is_english else None, | ||
| form.template_category_other.data if not is_english else None, | ||
| new_template.id, | ||
| ) | ||
| except HTTPError as e: | ||
| current_app.logger.error( | ||
| f"Failed to send new template category request to Freshdesk: {e} for template {new_template.id}, data is {form.template_category_other.data}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
I think this code should be down near service_api_client.update_service_template() on line 984. As-is I think there is a chance this is going to send the request when a user is previewing their template.
app/main/views/templates.py
Outdated
Comment on lines
1018
to
1033
| # Send the information in form's template_category_other field to Freshdesk | ||
| if form.template_category_other.data: | ||
| is_english = get_current_locale(current_app) == "en" | ||
| try: | ||
| current_user.send_new_template_category_request( | ||
| current_user.id, | ||
| current_service.id, | ||
| form.template_category_other.data if is_english else None, | ||
| form.template_category_other.data if not is_english else None, | ||
| new_template.id, | ||
| ) | ||
| except HTTPError as e: | ||
| current_app.logger.error( | ||
| f"Failed to send new template category request to Freshdesk: {e} for template {new_template.id}, data is {form.template_category_other.data}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Should this be here, again?
jzbahrai
force-pushed
the
task/add-freshdesk-cats
branch
from
4ad18c6 to
33ec66a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
andrewleith
approved these changes
Jul 22, 2024
jzbahrai
pushed a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
If the template creation/ edit form has data in the Other field - We will send that data to freshdesk
Test instructions | Instructions pour tester la modification
Unfortunately we don't have a freshdesk integration for staging. The code is try/ except blocks for this exact reason.