Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design tweaks for template categories #1917

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Design tweaks for template categories #1917

merged 2 commits into from
Jul 31, 2024

Conversation

amazingphilippe
Copy link
Contributor

Summary | Résumé

This PR tweaks little design details:

  • Template list grid layout works better across breakpoints by introducing one media query
  • Wrapped the filters nav in a div - required to play nicely with our details-polyfill. I also fixed the alignment issue we had
  • Applied small font size on the category label when editing a template.

Screenshots:

Grid:
Capture d’écran, le 2024-07-30 à 15 48 33
Capture d’écran, le 2024-07-30 à 15 48 39
Capture d’écran, le 2024-07-30 à 15 48 45

Filters:
Capture d’écran, le 2024-07-30 à 15 48 55

Category label:
Capture d’écran, le 2024-07-30 à 15 54 31

Test instructions | Instructions pour tester la modification

Compare with the screenshots above, play around with the window size.

Copy link

@YedidaZalik
Copy link

We are waiting for the translation for this figma content:https://www.figma.com/design/RLcM0JwlQsd2uVK3GJr5qY/Templates-%7C-Gabarits?node-id=3330-1476&t=JdTZBNSQkjrRUDWP-0
Marie-Sophie has been tagged.

Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking side-by-side at this and staging. I don't see any differences on the template list in the large size. Should there be some?

I do see:
✅ the filters being move over to the left
✅ the fixes and the medium and small sizes
✅ the smaller label on edit

@amazingphilippe
Copy link
Contributor Author

Should there be some?

Nope! The media query addressed the smallest viewport.

@amazingphilippe
Copy link
Contributor Author

We are waiting for the translation for this figma content:https://www.figma.com/design/RLcM0JwlQsd2uVK3GJr5qY/Templates-%7C-Gabarits?node-id=3330-1476&t=JdTZBNSQkjrRUDWP-0 Marie-Sophie has been tagged.

This would be for #1908 We don't need content for this one!

Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amazingphilippe amazingphilippe merged commit dce8425 into main Jul 31, 2024
10 checks passed
@amazingphilippe amazingphilippe deleted the design/tc-fixes branch July 31, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants