Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump certifi, werkzeug and utils #1941

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Bump certifi, werkzeug and utils #1941

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff89585
Bump certifi, werkzeug and utils
whabanks Sep 10, 2024
d00fede
Merge branch 'main' into sync-deps-with-utils
whabanks Sep 12, 2024
ce579b7
update lockfile
whabanks Sep 12, 2024
3b94d71
Merge branch 'main' into sync-deps-with-utils
whabanks Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 47 additions & 52 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,18 @@ ua-parser = "0.18.0"
user-agents = "2.2.0"
WTForms = "3.1.2"
email-validator = "1.3.1"
Werkzeug = "3.0.3"
Werkzeug = "3.0.4"
greenlet = "2.0.2"
mixpanel = "4.10.1"
unidecode = "^1.3.6"

# PaaS
awscli-cwlogs = "^1.4.6"
notifications-utils = { git = "https://github.com/cds-snc/notifier-utils.git", tag = "52.2.8" }
notifications-utils = { git = "https://github.com/cds-snc/notifier-utils.git", tag = "52.3.3" }

# Pinned dependencies
rsa = "^4.1" # not directly required, pinned by Snyk to avoid a vulnerability
certifi = "^2023.7.22" # Pinned for security reasons: https://github.com/cds-snc/notification-admin/security/dependabot/169
certifi = "^2024.0.0" # Pinned for security reasons: https://github.com/cds-snc/notification-admin/security/dependabot/169
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils is not forcing certifi 2024.0.0 so I think you can delete this line

Copy link
Contributor Author

@whabanks whabanks Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just doing the bump from the dependency dashboard here since we did bump certifi in utils and poetry was yelling at me 😅

Because notification-admin depends on notifications-utils (52.3.3) @ git+https://github.com/cds-snc/notification-utils.git@bump-patch-deps which depends on certifi (^2024.0.0), certifi is required.
So, because notification-admin depends on certifi (^2023.7.22), version solving failed.

redis = "3.5.3" # pinned for now
xlrd = "1.2.0" # this is pinned so that we can continue to support .xslm files; see https://github.com/pyexcel/pyexcel-xls/issues/53
# Putting upgrade on hold due to v1.0.0 using sha512 instead of sha1 by default
Expand Down
Loading