Add service setting to change annual limits for platform admins #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://34bdfghqzreicubogj33y6fxim0vbcsh.lambda-url.ca-central-1.on.aws/ |
andrewleith
approved these changes
Oct 23, 2024
app/main/views/service_settings.py
Outdated
| replace=reply_to_email_id, | ||
| ) | ||
| ) | ||
|
|
||
| if reply_to_email_address and request.endpoint == "main.service_confirm_delete_email_reply_to": | ||
| if not reply_to_email_address["is_default"]: | ||
| flash(_("Are you sure you want to delete this reply-to email address?"), "delete") | ||
| flash( |
There was a problem hiding this comment.
Still confused why formatting is constantly changing, as it creates a lot of noise. Is it possible our rules keep changing?
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR adds capability for platform admins to set annual email and sms limits for a service. It also changes the SMS and Email annual limit displays so they are no longer hard coded but fetched from the DB.
Test instructions | Instructions pour tester la modification
All
service-{id}keys need to be cleared when deployed to staging / prodflask db upgrade