-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limits for go-live form step 2 #1984
base: main
Are you sure you want to change the base?
Conversation
🧪 Review environmenthttps://4ugtwf2tgmnzquwrs7wtg6i7ka0epjtq.lambda-url.ca-central-1.on.aws/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amazingphilippe now that I can see how this appears in the interface, I agree that "How many" works!
I also realized that we could shorten the headings from
"About emails you want to send" to "Email" and "About text messages you want to send" to "Text messages"
I think that could reduce cognitive load. Is it too late to do that?
I agree! Not too late. Good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. A few comments about adding some tests due to the overall complexity of this particular form.
…dates' into feat/golive-form-updates
…dates' into feat/golive-form-updates
🧪 Review environmenthttps://fjo6iz3bzzx37ngx6kpwpuq4540rzsxk.lambda-url.ca-central-1.on.aws/ |
Summary | Résumé
Test instructions | Instructions pour tester la modification