Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezones and improved content on login history #1985

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

amazingphilippe
Copy link
Contributor

@amazingphilippe amazingphilippe commented Oct 31, 2024

Summary | Résumé

Adds in some content changes to the login events screen to

  • Clarify that time zones are local, except when otherwise marked
  • Make the titles a bit nicer.

Test instructions | Instructions pour tester la modification

  1. Log in to the app
  2. Check FR and EN screens. Make sure there is no missing translations.

Copy link

@amazingphilippe amazingphilippe marked this pull request as ready for review October 31, 2024 20:12
@@ -1899,7 +1899,7 @@
"total sends in the last 7 days","total des envois au cours des 7 derniers jours"
"Getting started","Découvrez comment fonctionne Notification GC"
"Check your service is running and not using a proxy we cannot access","Vérifiez que votre service est en cours d'exécution et n'utilise pas un proxy auquel nous ne pouvons pas accéder"
"Know your responsibilities","Ayez connaissance de vos responsabilités"
"By using GC Notify, you agree to:","En utilisant Notification GC, vous prenez les engagements suivants&thinsp:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing a ; in the   here.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof! missed this one! thanks!

Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 adjustment needed then LGTM!

@amazingphilippe amazingphilippe merged commit a1b800f into main Nov 4, 2024
11 checks passed
@amazingphilippe amazingphilippe deleted the fix/timezone-login-content branch November 4, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants