Fix two tests #1994
Fix two tests #1994
Conversation
sastels
force-pushed
the
fix/articles-test
branch
from
38784aa to
ceee6a9
Compare
🧪 Review environmenthttps://v2so6xivu2rh3sb37feonws5o40cvynp.lambda-url.ca-central-1.on.aws/ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| get_page_by_slug_with_cache(endpoint, params) | ||
|
|
||
| assert request_mock.called | ||
|
|
||
| assert mock_redis_method.get.called | ||
| assert mock_redis_method.get.call_count == 2 | ||
| assert mock_redis_method.get.called_with(cache_key) | ||
| assert mock_redis_method.get.call_count == 3 | ||
|
|
There was a problem hiding this comment.
The assert mock_redis_method.get(fallback_cache_key) == json.dumps(response_json) line should be placed before the assert mock_redis_method.get(fallback_cache_key) is not None line to ensure that the value is checked for equality first before checking for non-nullity.
There was a problem hiding this comment.
well, I dunno about the order but it's redundant to have both assertions there so I'll remove the non-nullity one and give the ai a 👍 for pointing it out.
| get_page_by_slug_with_cache(endpoint, params) | ||
|
|
||
| assert request_mock.called | ||
|
|
||
| assert mock_redis_method.get.called | ||
| assert mock_redis_method.get.call_count == 2 | ||
| assert mock_redis_method.get.called_with(cache_key) | ||
| assert mock_redis_method.get.called_with(fallback_cache_key) | ||
| calls = [call(cache_key), call(cache_key)] |
There was a problem hiding this comment.
The calls list should include the fallback_cache_key as well, since the test is verifying that there is no fallback when a 404 is received. The correct calls should be call(cache_key) and call(fallback_cache_key).
Summary | Résumé
When doing the Python upgrade I found two tests that weren't testing the right things (but passing anyway 😅 ). Figured I'd fix them on their own, the Python PR is complicated enough.
Test instructions | Instructions pour tester la modification
Verify that the tests still pass.