Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update config and text #1998

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

andrewleith
Copy link
Member

@andrewleith andrewleith commented Nov 20, 2024

Summary | Résumé

This PR updates some static content relating to annual limits.

Terms page

EN

image

FR

image

Terms of use dialog

EN

image

FR

image

Settings page

EN

image image

FR

image

Test instructions | Instructions pour tester la modification

Ensure the content updates were made correctly in the following places:

  • /terms
  • The service settings page of a service
  • The TOU dialog when creating a new account at /register

Copy link

Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The settings page should be fine in prod where the FF is off. I tested that when we pushed the code to allow changing annual limits for platform admins 🚀

@andrewleith andrewleith merged commit 4b4ac2b into main Nov 20, 2024
11 checks passed
@andrewleith andrewleith deleted the feat/update-text-for-annual-limits branch November 20, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants