Upgrade to latest New Relic version #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # | ||
| # Kubernetes config: | ||
| # https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/ | ||
| graceful_timeout = 85 |
Check notice
Code scanning / CodeQL
Unused global variable Note
| # Kubernetes config: | ||
| # https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/ | ||
| graceful_timeout = 85 | ||
| timeout = 90 |
Check notice
Code scanning / CodeQL
Unused global variable Note
jimleroyer
commented
Nov 20, 2024
| @@ -20,10 +22,34 @@ | |||
| # to be larger than the idle timeout configured for the load balancer. | |||
| # > By default, Elastic Load Balancing sets the idle timeout value for your load balancer to 60 seconds. | |||
| # https://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.html#connection-idle-timeout | |||
| on_aws = os.environ.get("NOTIFY_ENVIRONMENT", "") in ["production", "staging", "scratch", "dev"] | |||
There was a problem hiding this comment.
I don't know why we fell back on an empty string instead of the default None value. It seems unnecessary considering the following condition with the AWS env check.
🧪 Review environmenthttps://5l627b5ozouxuu3m3ees2bkxqm0lncbj.lambda-url.ca-central-1.on.aws/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Upgrade to latest New Relic version and bringing additional changes that were performed on the API side.
newrelic.inifile.fzfcommand line utility to the devcontainer along with proper shell config.Test instructions | Instructions pour tester la modification
Check the kubernetes admin pods startup to make sure that these do not get into a crash loop. It is possible we might have to align the admin k8s liveness, readiness and startup probes with the ones in API with their latest changes.