Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the translations #2020

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Fix the translations #2020

wants to merge 13 commits into from

Conversation

jzbahrai
Copy link
Contributor

Summary | Résumé

Add missing translations

Copy link

Added missing translation for provider response: "Phone is currently unreachable/unavailable"
Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing one message:
image

@andrewleith
Copy link
Member

andrewleith commented Dec 17, 2024

I fixed one string that didn't quite match the translation, as well as the some syntax that was preventing pybabel from detecting the missing translations. Instead of :
_('translation {'}.format(abc)) it should be _('translation {'}').format(abc)

@amazingphilippe , are there translations for these strings? I couldn't find them in figma!

  • For more information, visit the <a href={}>usage report for {}</a>.
  • <strong>{}</strong> cannot send any more {} until <strong>April 1, {}</strong>

Copy link
Contributor

@amazingphilippe amazingphilippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were missing translations in Figma as well:

"{} cannot send any more {} until April 1, {}","{} ne peut plus envoyer de courriels d’ici le 1<sup>er</sup> avril {}."
"For more information, visit the <a href={}>usage reports</a>.","Pour plus de détails, <a href={}>consulter les rapports d’utilisation</a>."

A few notes:

  • removed <strong>.
  • added a <sup> for properly formatting "1er" in FR
  • removed link text customization with the service name. Less tricky in FR. The service name is also in the sentence before.

Noticed 2 more things:

  • We nest p tags (we shouldn't)
  • We use the same font size for both paragraphs. Adding a class text-title to the first sentence in each condition would fix that.

app/templates/partials/check/too-many-messages-annual.html Outdated Show resolved Hide resolved
Copy link
Contributor

@amazingphilippe amazingphilippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some changes. Though I haven't run these and they seem like a lot to suggest in a review...

app/templates/partials/check/too-many-messages-annual.html Outdated Show resolved Hide resolved
app/templates/partials/check/too-many-messages-annual.html Outdated Show resolved Hide resolved
app/templates/partials/check/too-many-messages-annual.html Outdated Show resolved Hide resolved
app/translations/csv/fr.csv Outdated Show resolved Hide resolved
app/templates/partials/check/too-many-messages-annual.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants