-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the translations #2020
base: main
Are you sure you want to change the base?
Fix the translations #2020
Conversation
🧪 Review environmenthttps://orsem5cdpr2bug2w3ame6tmhha0awehs.lambda-url.ca-central-1.on.aws/ |
Added missing translation for provider response: "Phone is currently unreachable/unavailable"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…till need the actual french though
I fixed one string that didn't quite match the translation, as well as the some syntax that was preventing @amazingphilippe , are there translations for these strings? I couldn't find them in figma!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were missing translations in Figma as well:
"{} cannot send any more {} until April 1, {}","{} ne peut plus envoyer de courriels d’ici le 1<sup>er</sup> avril {}."
"For more information, visit the <a href={}>usage reports</a>.","Pour plus de détails, <a href={}>consulter les rapports d’utilisation</a>."
A few notes:
- removed
<strong>
. - added a
<sup>
for properly formatting "1er" in FR - removed link text customization with the service name. Less tricky in FR. The service name is also in the sentence before.
Noticed 2 more things:
- We nest p tags (we shouldn't)
- We use the same font size for both paragraphs. Adding a class
text-title
to the first sentence in each condition would fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some changes. Though I haven't run these and they seem like a lot to suggest in a review...
Co-authored-by: Philippe Caron <[email protected]>
Co-authored-by: Philippe Caron <[email protected]>
Co-authored-by: Philippe Caron <[email protected]>
Co-authored-by: Philippe Caron <[email protected]>
Co-authored-by: Philippe Caron <[email protected]>
Summary | Résumé
Add missing translations