Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Ruff checks formatting during CI checks #2021

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

whabanks
Copy link
Contributor

Summary | Résumé

  • Updated Ruff to 0.8.2.
  • Updated Ruff VScode extension to prevent automatic removal of unused imports on save. Unused imports will still be removed when make format is ran.
  • Ruff will now properly check formatting in CI.

Test instructions | Instructions pour tester la modification

  1. Dev container builds
  2. Open any python file and add an unused import from app import celery for example
  3. Save the file
  4. Note that the unused import was not removed and that the imports are highlighted indicating a linter error.
  5. Run make format
  6. Note that the unused import was removed.

- The VSCode ruff extension will no longer automatically remove unused imports but will still notify you they're incorrect
- Updated ruff to 0.8.2
Copy link

@whabanks whabanks merged commit 7863163 into main Dec 13, 2024
11 checks passed
@whabanks whabanks deleted the fix/formatter-check-in-ci branch December 13, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants