Add error message when notification size > 256KB #2025
+42
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR adds a front end error message, with guidance, when attempting to send a one off notification that exceeds the SQS size limit of 256KB.
Related work
Test instructions | Instructions pour tester la modification
Pull and run the above API PR when testing locally. From the UI there are only a couple scenarios where a notification can reach the 256KB limit by using variables in one-offs. This is because:
RecipientCSV
class has built in validation on column values and overall content length that prevent users from reaching the 256KB limit when performing bulk sends.Test 1
Test 2
var1_content.txt
into 3 and insert them into the newly added variables, keeping track of which variable holds the largest chunk