Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass staging rate limiting when running cypress tests #2046

Merged
merged 10 commits into from
Jan 13, 2025

Conversation

andrewleith
Copy link
Member

@andrewleith andrewleith commented Jan 10, 2025

Summary | Résumé

This PR updates the cypress test suite to pass a waf-secret header on every request to notify (including static resources) in order to bypass rate limiting.

Test instructions | Instructions pour tester la modification

  • Scheduled cypress tests do not fail due to 429 errors

Copy link

@andrewleith andrewleith marked this pull request as ready for review January 13, 2025 13:39
@andrewleith andrewleith changed the title fix: use waf-secret when getting static files, too Bypass staging rate limiting when running cypress tests Jan 13, 2025
Copy link
Contributor

@jzbahrai jzbahrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find!

@andrewleith andrewleith merged commit 8a47c0c into main Jan 13, 2025
11 checks passed
@andrewleith andrewleith deleted the fix/bypass-rate-limit-for-static-files-cypress branch January 13, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants