Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add command to make user a platform admin #2225

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Jul 18, 2024

Summary | Résumé

Command to toggle the user platform_admin setting.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

  • log into an api or celery pod
  • run the command flask command admin -u <your email address> --off
  • clear the users cache and verify that you are no longer an admin!
  • run the command flask command admin -u <your email address>
  • log into Notify again and verify that you are once more an admin.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels marked this pull request as ready for review July 22, 2024 12:02
@sastels sastels requested review from jimleroyer and ben851 July 22, 2024 12:02
Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As noted lets look at getting Terraform (or helm) to leverage using this command so we can track platform admins in code.

@sastels sastels merged commit 32737c5 into main Jul 22, 2024
4 checks passed
@sastels sastels deleted the set-user-platform-admin branch July 22, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants