Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celery crash if bad sending domain #1363

Open
sastels opened this issue Sep 27, 2023 · 0 comments
Open

Celery crash if bad sending domain #1363

sastels opened this issue Sep 27, 2023 · 0 comments
Assignees
Labels
Bug | Bogue Dev Task for implementation of a technical solution Refined l Affiné Stories and tasks that are ready to be worked on

Comments

@sastels
Copy link
Contributor

sastels commented Sep 27, 2023

Describe the bug

Celery crashes if a service has their sending domain set to one that's not in our verified list

Bug Severity

See examples in the documentation

SEV-4 Low

To Reproduce

Steps to reproduce the behavior:

  1. Set your sending domain to something invalid (ex: stevespizza.com)
  2. Send an email
  3. See a celery error similar to
Traceback (most recent call last):
  File "/app/app/clients/email/aws_ses.py", line 104, in send_email
    response = self._client.send_raw_email(Source=source, RawMessage={"Data": msg.as_string()})
  File "/app/.venv/lib/python3.10/site-packages/botocore/client.py", line 535, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/app/.venv/lib/python3.10/site-packages/botocore/client.py", line 980, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.MessageRejected: An error occurred (MessageRejected) when calling the SendRawEmail operation: Email address is not verified. The following identities failed the check in region CA-CENTRAL-1: Service <[email protected]>...
  1. See error

Expected behavior

  • Celery doesn't crash
  • would be nice if the log pointed out the problem better
  • bonus points would be not letting an admin put in an invalid sending domain in the first place. Sinice only an admin can make this change this would probably be more work than its worth.

Impact

  • Confusing error
  • emails don't send if this is set wrong
@jzbahrai jzbahrai added Dev Task for implementation of a technical solution Refined l Affiné Stories and tasks that are ready to be worked on labels Sep 27, 2023
@jzbahrai jzbahrai self-assigned this Dec 10, 2024
@andrewleith andrewleith assigned andrewleith and unassigned jzbahrai Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug | Bogue Dev Task for implementation of a technical solution Refined l Affiné Stories and tasks that are ready to be worked on
Projects
None yet
Development

No branches or pull requests

3 participants