-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/provide list of sending domains #2018
base: main
Are you sure you want to change the base?
Conversation
🧪 Review environmenthttps://m5nrumtltpawaqnq247ljuifoq0ocyll.lambda-url.ca-central-1.on.aws/ |
Is it easy to clear this from the cache, ie when we add a new one to AWS? (waiting 5 minutes is fine if this isn't already baked in somehow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and it worked, it doesn't work on admin preview though.
Hmm not really - I can add a function to clear it though. FYI it isn't using redis, its using |
….com/cds-snc/notification-admin into feat/provide-list-of-sending-domains
Summary | Résumé
This PR updates the sending domain admin page to use a list of verified sending domains from AWS instead of a drop down list which could allow users to enter invalid domains into.
Since this lists rarely changes the request to SES is cached for 5 minutes so we don't send too many requests.
Related cards
Before - textbox
After - dropdown
Test instructions | Instructions pour tester la modification