Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing French translation in Service settings #1686

Closed
jprince-cds opened this issue Oct 29, 2024 · 5 comments
Closed

Missing French translation in Service settings #1686

jprince-cds opened this issue Oct 29, 2024 · 5 comments

Comments

@jprince-cds
Copy link

Describe the bug

Sentence is missing a French translation on the screen to "Change your sending email address" in Service settings.

Bug Severity

Potential OL breach.

To Reproduce

Steps to reproduce the behavior:

  1. Switch your Notify language to French.
  2. Click on Paramètres of a service.
  3. Click on Modifier next to "Nom de l'adresse courriel d'envoi"
  4. See untranslated string: "You may use letters, numbers, dots, dashes or underscores."

Screenshots

image.png

Additional context

Reported in Freshdesk Ticket #19708

@yaelberger-commits
Copy link
Collaborator

@amazingphilippe and @YedidaZalik this is a bug we should prioritize because it's on a visible page

@amazingphilippe amazingphilippe self-assigned this Nov 4, 2024
@YedidaZalik
Copy link

@amazingphilippe
Copy link
Collaborator

We can probably reuse content from the create-a-service flow

@amazingphilippe
Copy link
Collaborator

Pull request to fix the issue: cds-snc/notification-admin#1988

@yaelberger-commits
Copy link
Collaborator

Merged and released
Has been QA'd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants