Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content on the email address settings page #1988

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

amazingphilippe
Copy link
Contributor

Summary | Résumé

After changing the creat a service flow, we must've forgottent to check the contents of the settings page where one can change a service sending email address.

this PR updates the content of that page, so that it matches other changes we did, and most importantly fixes a missing translation.

Test instructions | Instructions pour tester la modification

  1. In any service
  2. In the settings
  3. Click on the sending email address settings
  4. You should be on "Change your sending email address"
  5. Toggle to FR and make sure there is no English content
  6. Test the live preview functionality
  7. Save the form and check that the value was saved properly.

app/config.py Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto formatting...

Copy link

github-actions bot commented Nov 4, 2024

Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up. Looks like there is just a small issue with a line break that is breaking one translation, see below.

app/templates/views/service-settings/email_from.html Outdated Show resolved Hide resolved
app/templates/views/service-settings/email_from.html Outdated Show resolved Hide resolved
Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amazingphilippe amazingphilippe merged commit be63286 into main Nov 13, 2024
11 checks passed
@amazingphilippe amazingphilippe deleted the fix/chang-email-address-form branch November 13, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants