-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix content on the email address settings page #1988
Conversation
app/config.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto formatting...
🧪 Review environmenthttps://jkn3ecle32c4x5gk5do5rcktha0jirti.lambda-url.ca-central-1.on.aws/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up. Looks like there is just a small issue with a line break that is breaking one translation, see below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary | Résumé
After changing the creat a service flow, we must've forgottent to check the contents of the settings page where one can change a service sending email address.
this PR updates the content of that page, so that it matches other changes we did, and most importantly fixes a missing translation.
Test instructions | Instructions pour tester la modification