Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/pre 3.12 recipient csv annual limit validation merge in to main #341

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Dec 13, 2024

Summary | Résumé

Take the branch task/pre-3.12-recipient-csv-annual-limit-validation that is currently being used in production and merge it into the Python 3.12 main.

This will allow us to update and test the 3.12 api PR to main and test it without touching the utils branch being used in main.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

  • build (locally) and push to dev
  • test in dev in the AWS console.
  • Will release to staging and test there with a 50K perf test and a couple hours of roller coaster tests

Release Instructions | Instructions pour le déploiement

Cross your fingers.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants