Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove amplify test phase, move axe to gh actions #68

Merged
merged 3 commits into from
Jun 13, 2022
Merged

remove amplify test phase, move axe to gh actions #68

merged 3 commits into from
Jun 13, 2022

Conversation

daine
Copy link
Collaborator

@daine daine commented Jun 13, 2022

Summary | Résumé

remove amplify test phase, move axe to gh actions

@github-actions
Copy link

TF Plan for app

✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_amplify_app.learning_resources will be updated in-place
  ~ resource "aws_amplify_app" "learning_resources" {
      ~ build_spec                    = <<-EOT
            version: 1
            frontend:
              phases:
                preBuild:
                  commands:
                    - cd app
                    - cp .contentful.json.sample .contentful.json
                    - npm install
                build:
                  commands:
                    - npm run generate
              artifacts:
                baseDirectory: app/dist
                files:
                  - '**/*'
              cache:
                paths:
                  - node_modules/**/*
            test:
          -   artifacts: 
          -     baseDirectory: app
              phases:
                preTest:
                  commands:
                    - cd app
                    - cp .contentful.json.sample .contentful.json
                    - npm ci
          -         - npm install -g pm2
          -         - npm install -g wait-on
          -         - npm install @axe-core/cli
          -         - npm run build
          -         - pm2 start npm -- start
          -         - wait-on http://localhost:3000
          +         - npm install -g @axe-core/cli
          +         - npm run start
                test:
                  commands:
          -         - npx axe http://localhost:3000 --exit
          +         - axe http://localhost:3000 --exit
        EOT
        id                            = "d1aa42w7dd40bx"
        name                          = "learning-app"
        tags                          = {}
        # (16 unchanged attributes hidden)


        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Releasing state lock. This may take a few moments...
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.app"]
WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.main"]
WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources"]
WARN - plan.json - main - Missing Common Tags: ["aws_amplify_app.learning_resources_storybook"]
WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main"]
WARN - plan.json - main - Missing Common Tags: ["aws_amplify_branch.main_storybook"]
WARN - plan.json - main - Missing Common Tags: ["aws_ecr_repository.learning_resources"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.app"]

25 tests, 17 passed, 8 warnings, 0 failures, 0 exceptions

@daine daine merged commit 1ea503b into main Jun 13, 2022
@daine daine deleted the axe branch June 13, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant