Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

Dev #124

Merged
merged 47 commits into from
Apr 5, 2019
Merged

Dev #124

merged 47 commits into from
Apr 5, 2019

Conversation

sayaHub
Copy link
Contributor

@sayaHub sayaHub commented Apr 2, 2019

sorry for this big PR. Merging the Dev branch to Master in order to bring Master to par with what is
running on the Live HTTPS dashboard site.

Some diff in Dev:

  • implementation of Google Tag Manager and removal of Google Analytic implementation
  • implementation of Public and Internal Dashboard view ( might be temporary)

cheers,
Saya

obrien-j and others added 30 commits October 5, 2018 20:48
…returning both a datetime, or a str. Whoops.
- removed Bold links in some pages
- add Terms and Conditions in footers
- add Content Security Policy on header
- moved some inline javascript call to a external file
…pp URL.

  for now : only one report name is allowed : compliance
@obrien-j
Copy link
Contributor

obrien-j commented Apr 2, 2019

This pull request introduces 2 alerts when merging f6e1980 into d00add1 - view on LGTM.com

new alerts:

  • 1 for Missing variable declaration
  • 1 for Unused variable, import, function or class

Comment posted by LGTM.com

Copy link
Contributor

@obrien-j obrien-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

🍻 to no more big integrations!

@obrien-j obrien-j merged commit 19b1be1 into master Apr 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants