Add Prior knowledge for LiM #145 #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add prior knowledge option for LiM class. Each element of the prior knowledge matrix should be 0 (unconnected) or -1 (unknown). Modifications to the algorithm are: Set bounds of variables of unconnected path as 0 for L-BFGS on global search. Omitting paths of those to be unconnected for local search.
|
Dear yujota, Thanks for implementing prior knowledge for LiM. The modified codes look feasible and ok. But please note that LiM optimizes the adjacency matrix about the directed EDGES. Element "1" in the matrix means the existence of the directed edge, other than the directed PATH. Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. Thank you for sharing wonderful lib.
I implemented prior knowledge for LiM, related to issue #145.
Still, I'm wondering if this implementation is theoretically ok.
I look forward to your suggestion.