Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login.gov requires a nonce field to be generated for each session.
This is a first pass on using the session id to generate a random 32 character string. We store this IN MEMORY until we get it back (which should be almost immediately) and then remove it. We met the basic requirements specified by login.gov but going forward we may consider using a hash instead of a random number generator.
From login.gov docs-
From OpenId spec-
Also it looks like Spring Security 5 planned to support it but recently dropped it to the backlog
spring-projects/spring-security#4442
Also an old spring library offers an in memory nonce service we could think about using.
InMemoryNonceServices
closes #769