Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Update Nuget targets to link unmanaged resources #2156

Closed
amaitland opened this issue Oct 9, 2017 · 5 comments
Closed

Comments

@amaitland
Copy link
Member

amaitland commented Oct 9, 2017

https://stackoverflow.com/a/30316946/4583726
https://msdn.microsoft.com/en-us/library/0c6xyb66(VS.80).aspx

Above link suggests adding unmanaged files using a none target and setting a link, should improve support for for creating library projects that reference CefSharp.

Just adding as reference in case anyone wants to take up the challenge.

@perlun
Copy link
Member

perlun commented Dec 2, 2017

Thanks for the suggestion @amaitland! I hope someone has the time to investigate this sometime, it would be a nice addition for certain use cases.

@amaitland
Copy link
Member Author

cef.redist packages were restructed to as part of this change, the .targets files were renamed to .props, see cefsharp/cef-binary@9eef26e for details

This actually represented a much larger change than I initially though, it's been implemented in 0e25149 and has been, files appear to be correctly copied when using a Library project (only one level deep worth of referencing is supported by msbuild).

Clickonce should also now be supported as all files are included by <None/> entries.

Ideally would move the OffScreen, WinForms and WPF targets file content to the props (as they're actually props now), unfortunately we need guaranteed ordering and Nuget 2.8.x doesn't provide that, if we leave them as .targets it'll happen late enough to make sure the cef.redist list of files is provided.

NuGet/Home#4229 (comment)

amaitland added a commit that referenced this issue Jan 23, 2018
Resolves #2156

Nuget packages updated to use ItemGroup None instead of Copy target
Nuget props restructure to support Win32 target
x86 and Win32 targets are exactly the same in content, they differ in name only, so switched to using an <Otherwise/> block
Remove AnyCpu <When/> option from props files and consolidate with x86 and Win32. Set Private to false and rely on the
<None/> entires to copy the files to the output folder

Ideally would move the OffScreen, WinForms and WPF targets file content to the props (as they're actually props now), unfortunately
we need guaranteed ordering and Nuget 2.8.x doesn't provide that, if we leave them as .targets it'll happen late enough to make sure
the cef.redist list of files is provided.
NuGet/Home#4229 (comment)
@thicout
Copy link

thicout commented Feb 13, 2018

Hi. I am targeting AnyCPU, and since 63.0.0, I can’t use Visual Studio Designer anymore.
I can reproduce the issue with the MinimalExample (starting with 55.0.0 for example).

My problem with 63.0.0 (and 63.0.1) is that, when I target AnyCPU, the CefSharp references are now x64, so the Visual Studio Designer doesn’t work. With 57.0.0 the references were x86 when targeting AnyCPU, and I had no issue using the Visual Studio Designer.
The build / run of the app is working good with 63.0.0, but I can’t work with the Visual Studio Designer.

I also noticed that after the installation of 63.0.0, an AnyCPU Project Plateform is automatically added in the Plateform combobox list in Visual Studio Configuration Manager.
It ends with two AnyCPU items in the Plateform combobox list, if an AnyCPU Plateform was present before the installation of 63.0.0. And I had strange behavior when I tried to remove the plateform.

If I downgrade to 57.0.0, everything is working back as expected.

@amaitland
Copy link
Member Author

Please open a new issue

@thicout
Copy link

thicout commented Feb 13, 2018

Ok, I created issue #2276.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants