Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship d3dcompiler_47.dll on ARM64 #4515

Closed
amaitland opened this issue Jun 3, 2023 · 2 comments
Closed

Ship d3dcompiler_47.dll on ARM64 #4515

amaitland opened this issue Jun 3, 2023 · 2 comments
Assignees
@amaitland
Milestone
115.2.x

Comments

@amaitland
Copy link
Member

chromiumembedded/cef#3515
@amaitland amaitland self-assigned this Jun 3, 2023
@kpreisser
Copy link
Contributor

I think this can be fixed by just reverting the changes from #3841, so that d3dcompiler_47.dll is no longer treated specially in the DependencyChecker.

@amaitland amaitland added this to the 114.2.x milestone Jun 9, 2023
@amaitland
Copy link
Member Author

Confirming the nuget package contains d3dcompiler_47.dll.

PR for the proposed change would be most welcome 👍

@amaitland amaitland modified the milestones: 114.2.x, 115.2.x Jul 26, 2023
amaitland added a commit that referenced this issue Aug 2, 2023
@amaitland
Revert "Don't check for presence of "d3dcompiler_47.dll" when running…
9abdaef 
… as ARM64, because that file isn't present in the CEF Redist for this architecture. (#3841)"

This reverts commit 0812ea9.

Resolves #4515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaitland amaitland

Labels
None yet
Projects
None yet
Milestone
115.2.x
Development

No branches or pull requests
2 participants
@amaitland @kpreisser