Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript Integration - Passing empty array in JS now maps to empty list/array instead of null #2829

Merged
merged 4 commits into from
Jul 20, 2019

Conversation

angshuman-agarwal
Copy link
Contributor

Summary: [When Empty Array is passed from JS, do not set Null]

  • Always set an empty list instead of Null

Changes: [specify the structures changed]

  • I have modified the SerializeV8Object Implementation
    • In case of arrays, moved the list creation out of the if statement & then always setting the list to the set index.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@amaitland
Copy link
Member

Please add some QUnit tests.

https://github.com/cefsharp/CefSharp/blob/master/CefSharp.Example/JavascriptBinding/AsyncBoundObject.cs
https://github.com/cefsharp/CefSharp/blob/master/CefSharp.Example/Resources/BindingTest.html

A more meaningful PR title is required, Set empty list instead of null doesn't mean much to anyone reading the change log or release notes.

@amaitland amaitland added this to the 75.0.0 milestone Jul 8, 2019
@angshuman-agarwal angshuman-agarwal changed the title Set empty list instead of null When a Javascript array is empty, serialize it as empty list instead of setting null Jul 8, 2019
@angshuman-agarwal
Copy link
Contributor Author

Please add some QUnit tests.

Done

A more meaningful PR title is required

Done

@AppVeyorBot
Copy link

@amaitland amaitland changed the title When a Javascript array is empty, serialize it as empty list instead of setting null Javascript Integration - Passing empty array in JS now maps to empty list/array instead of null Jul 12, 2019
@amaitland amaitland merged commit 48eaff8 into cefsharp:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants