Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.ps1 - escape commas for PowerShell #2901

Closed
wants to merge 1 commit into from

Conversation

chris-araman
Copy link
Contributor

@chris-araman chris-araman commented Sep 11, 2019

Fixes #2395 (comment) from @ray007

Summary:

  • Resolves errors of the form:
Could not parse command line parameter 'CefSharp.Wpf.Example'.
An unexpected error occurred | [GitLinkException] GitLink.GitLinkException: Could not parse command line parameter 'CefSharp.Wpf.Example'.
   at GitLink.ArgumentParser.ParseArguments(List`1 commandLineArguments, IProviderManager providerManager)
   at GitLink.Program.Main(String[] args)

Changes:

  • Escape commas in GitLink command line for PowerShell

How Has This Been Tested?

  • Ran build.ps1. Ensured GitLinkException did not appear.

Screenshots (if appropriate):

  • N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code (if applicable)
  • Commented my code
  • Changed the documentation (if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

Wasn't sure whether you'd prefer this against master or latest release cefsharp/75. I can create a new PR for master if you'd prefer.

@AppVeyorBot
Copy link

@amaitland
Copy link
Member

Thanks, please target against master please.

Under what circumstance is this change required? The args are passed successfully in the CI builds. Comparing build output and it's no different.
https://ci.appveyor.com/project/cefsharp/cefsharp/builds/27345657
https://ci.appveyor.com/project/cefsharp/cefsharp/builds/27274201

@chris-araman chris-araman changed the base branch from cefsharp/75 to master September 12, 2019 08:32
@chris-araman chris-araman changed the base branch from master to cefsharp/75 September 12, 2019 08:32
@chris-araman
Copy link
Contributor Author

We see these errors consistently. Perhaps because we're building on Windows Server 2016, or perhaps because we're invoking build.ps1 from an outer PowerShell script? I'm not certain. Maybe @ray007 can help us narrow down the variance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants