Calling browser close in managedcefbrowseradapter destructor #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jornh
added a commit
that referenced
this pull request
Apr 1, 2014
Calling browser close in managedcefbrowseradapter destructor
|
@jornh and @JanEggers I just did a few more checks with the latest dispose pattern this does work as mentioned! Woohoo, looking for other resource issues as I move forward. @jornh I will take a look at #249 when I have some time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've included two small superficial changes.
8b6248bSmall formatting changes.cae957aThe other half of the cookies datetime granularity in the visit api.39742b6We have a case where we close the browser core beforeOnApplicationExitand need to manage the resources better. CallingClose()in the destructor to ensure the client adapter calls->CloseBroswer()when disposed inwebview.cs.