-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import CefSharp.Wpf.HwndHost into main repository. #4981
base: master
Are you sure you want to change the base?
Conversation
Still a few thing to resolve
|
❌ Build CefSharp 130.1.90-CI5096 failed (commit ae53ed4b50 by @amaitland) |
I was hoping to have this done for |
Need to manually cherry pick changes from PR cefsharp/CefSharp.Wpf.HwndHost#31 |
90ee64d
to
d5fd7ba
Compare
❌ Build CefSharp 131.2.70-CI5106 failed (commit dd051548c7 by @amaitland) |
✅ Build CefSharp 131.2.70-CI5116 completed (commit f97afa386e by @amaitland) |
/// DelegateCommand | ||
/// </summary> | ||
/// <seealso cref="System.Windows.Input.ICommand" /> | ||
internal class DelegateCommand : ICommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be removed in favor of
CefSharp/CefSharp.Wpf/DelegateCommand.cs
Line 14 in a81202b
internal class DelegateCommand : ICommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent suggestion! Thanks.
✅ Build CefSharp 131.2.70-CI5118 completed (commit 02f8d697b6 by @amaitland) |
Probably need to revisit these, little bit hacky creating the window
Example will be removed shortly, so it doesn't matter too much now. It will be moved to MinimalExample and the Wpf Example expanded
83f4414
to
848e1eb
Compare
✅ Build CefSharp 131.3.10-CI5122 completed (commit 440a946ebe by @amaitland) |
❌ Build CefSharp 131.3.10-CI5124 failed (commit d8816e3d63 by @amaitland) |
Fixes: [issue-number]
#4982
Summary:
Changes:
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: