-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Windows ARM64 #90
Conversation
- Build win-arm64 version of libcef_dll_wrapper.lib when using the v141 (VS 2017) or v142 (VS 2019) toolchain. Issue cefsharp/CefSharp#2944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Thanks.
We'll also need to create a cef.redist Nuget package for use internally.
AppVeyor currently only builds VS2015 and VS2017 targets, hopefully it has the arm64 tools installed.
Let me know when you are happy and I'll merge this and tag a release, easiest way to have AppVeyor generate a build, see what happens. |
👍 Thank you! |
The build failed when trying to build for
This is probably the same issue as described here ( |
Looks promising though 👍
Happy to try that. Quick search and I see plenty of people attempting to reset the environment. We could potentially spawn a VS developer tools window for each build, they'd be isolated, lot more work involved though. |
Issue cefsharp/CefSharp#2944
88.1.2+gac8e5f0+chromium-88.0.4324.27
.win-arm64
artifacts to NuGet packagechromiumembeddedframework
and tocef.redist.arm64
.win-arm64
version oflibcef_dll_wrapper.lib
when using thev141
(VS 2017) orv142
(VS 2019) toolchain (for packagecef.sdk
).With this change, the ARM64
libcef_dll_wrapper.lib
builds successfully for me when using thev141
(VS 2017) andv142
(VS 2019) toolchains (when VC++ ARM64 build tools are installed).Thank you!