-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Russian language support #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will need another russ speaking person to double check. can you tag someone you know
Guys, could you be so kind and help with double check the PR for Russian language support for django-celery-results? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Native Russian Speaker)
Co-authored-by: Stepan Rakitin <[email protected]>
Co-authored-by: Stepan Rakitin <[email protected]>
Co-authored-by: Stepan Rakitin <[email protected]>
Co-authored-by: Stepan Rakitin <[email protected]>
|
||
#: django_celery_results/models.py:68 django_celery_results/models.py:176 | ||
msgid "Created DateTime" | ||
msgstr "ДатаВремя создания" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think «Дата и время» would be more russian then «ДатаВремя»
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with all proposed changes
Will apply them ASAP
msgid "" | ||
"JSON meta information about the task, such as information on child tasks" | ||
msgstr "" | ||
"JSON мета информация о Задании, такая как информация о дочерних Заданиях" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be «метаинформация» instead of «мета информация»
|
||
#: django_celery_results/models.py:92 | ||
msgid "task results" | ||
msgstr "результаты задания" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is verbose_name_plural
— a name for multiple instances of a task result, so it would be better as «результаты заданий»
msgid "" | ||
"JSON serialized list of task result tuples. use .group_result() to decode" | ||
msgstr "" | ||
"JSON сериалованный список таплов результата задания. Используйте .group_result() для декодирования" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google trends show that «кортеж» из more popular translation for Tuple then «тапл»
fixes are welcome |
I created #256 with suggested fixes, could you guys please check it out? |
Russian locale file is added