Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPIC: Single Binary Syncs #1568

Closed
1 task done
evan-forbes opened this issue Mar 30, 2023 · 3 comments
Closed
1 task done

EPIC: Single Binary Syncs #1568

evan-forbes opened this issue Mar 30, 2023 · 3 comments
Assignees
@cmwaters
Labels
epic item groups other items for easier tracking WS: V2 ✌️ lemongrass hardfork related
Milestone
v2

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Mar 30, 2023 •
edited by rootulp
Loading

We want to be able to sync from genesis using a single binary. This means that all past and present consensus logic needs to be maintained forever. The general thinking is that we will use the app version in the header to determine

more details in the ADR #1521

Tasks
@evan-forbes evan-forbes added the epic item groups other items for easier tracking label Mar 30, 2023
@evan-forbes evan-forbes added this to the Post-mainnet milestone Mar 30, 2023
@evan-forbes evan-forbes mentioned this issue Apr 21, 2023
Merged
5 tasks
evan-forbes added a commit that referenced this issue Apr 27, 2023
@evan-forbes @rootulp @renaynay
feat!: Implement the version module (#1640)
f2a18f4 
## Overview

This PR adds a very minimal version module, which will update the app
version in the header using end block based on a config. The configs are
just hardcoded maps atm, but its possible for a user to pass their own
via app options. This PR also isn't meant to be a final solution for
#1014 or #1568, but more of an exploratory demo of one way they could
done.

the majority of #1594 

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

---------

Co-authored-by: Rootul P <[email protected]>
Co-authored-by: rene <[email protected]>
@evan-forbes evan-forbes modified the milestones: Post-mainnet, v2 Nov 12, 2023
@staheri14
Copy link
Collaborator

Given that #1521 is now closed, it might be good to instead refer to this PR #1562 for details.

@rootulp rootulp mentioned this issue Jan 12, 2024
Merged
5 tasks
@rootulp rootulp added the WS: V2 ✌️ lemongrass hardfork related label Mar 1, 2024
@rootulp
Copy link
Collaborator

rootulp commented Mar 12, 2024

@cmwaters will close this when in-flight PRs related to multi versioned state machine get merged. Separate but related: we can revisit if we need to support "single binary syncs" when we cut celestia-app v3.

@rootulp
Copy link
Collaborator

rootulp commented Mar 20, 2024

@cmwaters is this close-able? I'm not sure which in-flight PRs were alluded to in my previous comment but I don't see any current in-flight PRs related to this.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Engineering Team Epics Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwaters cmwaters

Labels
epic item groups other items for easier tracking WS: V2 ✌️ lemongrass hardfork related
Projects
Engineering Team Epics
Status: Done
Milestone
v2
Development

No branches or pull requests
4 participants
@rootulp @cmwaters @staheri14 @evan-forbes