Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blob: SubmitPayForBlob should allow configurable broadcast mode #1885

Closed
Wondertan opened this issue Jun 6, 2023 · 1 comment · Fixed by #2307
Closed

blob: SubmitPayForBlob should allow configurable broadcast mode #1885

Wondertan opened this issue Jun 6, 2023 · 1 comment · Fixed by #2307

Comments

@Wondertan
Copy link
Member

Wondertan commented Jun 6, 2023 •
edited
Loading

Or use the sync instead of block.

As per @evan-forbes, block is going to be deprecated soonish, so we should stop using it. Additionally, it causes problems for the Dymension team
@Wondertan
Copy link
Member Author

Making it sync may also resolve issue Astria is facing: astriaorg/astria#122

@Wondertan Wondertan mentioned this issue Jun 28, 2023
Closed
@renaynay renaynay mentioned this issue Jul 5, 2023
Open
@Wondertan Wondertan mentioned this issue Jul 26, 2023
Merged
5 tasks
@evan-forbes evan-forbes mentioned this issue Aug 17, 2023
Merged
5 tasks
evan-forbes added a commit that referenced this issue Aug 17, 2023
@evan-forbes
feat!: make submitPFB broadcast mode configurable (#2307)
376132a 
## Overview

closes #1885

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
mergify bot pushed a commit that referenced this issue Aug 17, 2023
@evan-forbes @mergify
feat!: make submitPFB broadcast mode configurable (#2307)
30caa6e 
## Overview

closes #1885

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

(cherry picked from commit 376132a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: make submitPFB broadcast mode configurable celestiaorg/celestia-app
1 participant
@Wondertan