chore: remove unnecessary legacy handler from qgb module #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
added
the
backport:v1.x
rootulp
reviewed
Oct 9, 2023
| @@ -114,7 +114,7 @@ func (am AppModule) Name() string { | |||
|
|
|||
| // Route returns the capability module's message routing key. | |||
| func (am AppModule) Route() sdk.Route { | |||
| return sdk.NewRoute(types.RouterKey, NewHandler(am.keeper)) | |||
| return sdk.Route{} | |||
There was a problem hiding this comment.
[noob question] why is this Route method considered legacy? I've found it confusing when Cosmos SDK deprecates things b/c there isn't a consistent practice: some things are labeled "legacy" but not actually deprecated or removed.
There was a problem hiding this comment.
100% confusing. Well, the rationale is if the msg service is defined, then it will route the transaction correctly. Only if it is unable to that it will call the Legacy handler. In our case, we have the msg service, so we can delete this one instead of having to maintain almost the same logic in two places
There was a problem hiding this comment.
Here's where we perform the if statement just FYI:
There was a problem hiding this comment.
Fwiw they do mention it is deprecated under the interface itself here:
It's just that renaming the method would be breaking so they can only add a comment
evan-forbes
approved these changes
Oct 10, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords (cherry picked from commit 3914153)
rach-id
added a commit
that referenced
this pull request
Oct 11, 2023
) (#2647) This is an automatic backport of pull request #2635 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: CHAMI Rachid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checklist