Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ledger nano s+ (backport #4146) #4172

Merged
merged 2 commits into from
Jan 2, 2025
Merged

fix: ledger nano s+ (backport #4146) #4172

merged 2 commits into from
Jan 2, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 2, 2025

Closes #4106 by upgrading to cosmos-ledger-go v0.14.0

Testing

I verified that a Ledger Nano X can still submit a PFB on Celestia (see gist). I don't have a Ledger Nano S+ to test with 😞


This is an automatic backport of pull request #4146 done by Mergify.

Closes #4106 by
upgrading to cosmos-ledger-go v0.14.0

## Testing

I verified that a Ledger Nano X can still submit a PFB on Celestia (see
[gist](https://gist.github.com/rootulp/0d16d76814a6169c38ac0e9cca86cc58)).
I don't have a Ledger Nano S+ to test with 😞

(cherry picked from commit 13149fc)

# Conflicts:
#	test/interchain/go.mod
#	test/interchain/go.sum
Copy link
Contributor Author

mergify bot commented Jan 2, 2025

Cherry-pick of 13149fc has failed:

On branch mergify/bp/v3.x/pr-4146
Your branch is up to date with 'origin/v3.x'.

You are currently cherry-picking commit 13149fc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   go.mod
	modified:   go.sum

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/interchain/go.mod
	both modified:   test/interchain/go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team as a code owner January 2, 2025 15:17
@mergify mergify bot added the conflicts label Jan 2, 2025
@mergify mergify bot requested review from cmwaters and evan-forbes January 2, 2025 15:17
@github-actions github-actions bot added the bot item was created by a bot label Jan 2, 2025
@rootulp rootulp self-assigned this Jan 2, 2025
@rootulp rootulp requested review from ninabarbakadze and removed request for evan-forbes January 2, 2025 15:42
@rootulp rootulp enabled auto-merge (squash) January 2, 2025 15:53
@rootulp rootulp merged commit 29d4409 into v3.x Jan 2, 2025
28 of 29 checks passed
@rootulp rootulp deleted the mergify/bp/v3.x/pr-4146 branch January 2, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants