refactor: use slices.Contains

[zhuhaicity]

Overview

This is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the isKnownChainID function in the download_genesis.go file and the startCmd function in the start.go file within the cmd/celestia-appd/cmd directory. Both changes replace custom contains functions with the slices.Contains function from the standard library, streamlining the implementation for checking the presence of a string in a slice. The overall functionality remains unchanged, and there are no impacts on control flow or error handling in related functions.

Changes

File	Change Summary
cmd/celestia-appd/cmd/download_genesis.go	Replaced custom contains function with slices.Contains from the standard library.
cmd/celestia-appd/cmd/start.go	Replaced custom contains function with slices.Contains from the standard library.

No changes were made to exported or public entity declarations.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc09e5b and be37c49.

📒 Files selected for processing (2)

• cmd/celestia-appd/cmd/download_genesis.go (2 hunks)
• cmd/celestia-appd/cmd/start.go (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• cmd/celestia-appd/cmd/download_genesis.go

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Summary

🔇 Additional comments (2)

cmd/celestia-appd/cmd/start.go (2)

14-14: LGTM! Good use of standard library.

Using the slices package from Go 1.21 standard library is a good choice for slice operations.

---

136-138: LGTM! Clean refactor using standard library.

Good replacement of custom contains check with slices.Contains. The change:

• Improves code readability
• Reduces maintenance burden by using standard library
• Maintains the same functionality for public network validation

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[zhuhaicity]

Modified. Please review again.

[rootulp]

LGTM if CI passes

[ninabarbakadze]

bunch of things failing in the ci

[rootulp]

Looks like contains is used in more than that one location so CI is failing

[zhuhaicity]

Looks like contains is used in more than that one location so CI is failing

Indeed..has been modified.

Please review again.

[rootulp]

LGTM if CI passes

[zhuhaicity]

LGTM if CI passes

There is an error in ci-release / markdown-linter / markdown-link-check (pull_request), but it does not seem to be related to this PR’s change.

[rootulp]

Yea, you can ignore the markdown link check failure.