Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API testing #2337

Open
Wondertan opened this issue Jun 7, 2023 · 3 comments
Open

API testing #2337

Wondertan opened this issue Jun 7, 2023 · 3 comments
Assignees
Labels
area:api Related to celestia-node API kind:testing Related to unit tests swamp Related to Integration tests

Comments

@Wondertan
Copy link
Member

Currently, we test high-level APIs via Swamp through Go APIs. However:

We should investigate which modules lack API coverage and ensure we test them directly over Go interfaces and over RPC.

@Wondertan Wondertan added swamp Related to Integration tests area:api Related to celestia-node API labels Jun 7, 2023
@Wondertan
Copy link
Member Author

Related #2240 as we need a way to nicely abstract nodes running over RPC and over direct Go

@distractedm1nd distractedm1nd self-assigned this Jun 7, 2023
@Wondertan
Copy link
Member Author

Per sync discussion with @distractedm1nd we agree on the following order of execution:

@walldiss
Copy link
Member

We should consider creating a testing app that imports the Celestia client and runs a test suite over the network. This will enable us to:

  • Test RPC locally within the swamp against a real node connected to the same mocknet.
  • Run tests against a mock node (akin to a unit test of the representation layer) to ensure the RPC client isn't broken.
  • Run CI tests where the client and server are independent containers. These tests would be manual and only run during releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Related to celestia-node API kind:testing Related to unit tests swamp Related to Integration tests
Projects
None yet
Development

No branches or pull requests

4 participants