Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shwap): Add namespace data shwap id #3587

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

walldiss
Copy link
Member

Add namespaced data shwap id message

@walldiss walldiss added kind:feat Attached to feature PRs shwap labels Jul 22, 2024
@walldiss walldiss self-assigned this Jul 22, 2024
share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
share/shwap/namespace_data_id.go Show resolved Hide resolved
share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
@walldiss walldiss force-pushed the add-nd-shwap-type branch from 8e7f538 to 24baf17 Compare July 22, 2024 22:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 62.85714% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (shwap@d807843). Learn more about missing BASE report.

Files Patch % Lines
share/shwap/namespace_data_id.go 62.85% 7 Missing and 6 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             shwap    #3587   +/-   ##
========================================
  Coverage         ?   47.70%           
========================================
  Files            ?      317           
  Lines            ?    18605           
  Branches         ?        0           
========================================
  Hits             ?     8875           
  Misses           ?     8598           
  Partials         ?     1132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
share/shwap/namespace_data_id.go Outdated Show resolved Hide resolved
@walldiss walldiss merged commit 6fc490b into celestiaorg:shwap Jul 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat Attached to feature PRs shwap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants