feat(shwap/ods_file): tail padding trim #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
added
kind:testing
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
cristaloleg
reviewed
Aug 3, 2024
cristaloleg
reviewed
Aug 3, 2024
walldiss
reviewed
Aug 7, 2024
2 tasks
Wondertan
force-pushed
the
shwap-decouple-files
branch
from
4cccb18 to
5a4dff4
Compare
Wondertan
force-pushed
the
shwap-decouple-files
branch
from
5a4dff4 to
5b76ed5
Compare
Wondertan
force-pushed
the
shwap-trim
branch
2 times, most recently
from
5ccec35 to
e242456
Compare
Wondertan
force-pushed
the
shwap-decouple-files
branch
6 times, most recently
from
21198cc to
9e6bcb9
Compare
Wondertan
force-pushed
the
shwap-decouple-files
branch
6 times, most recently
from
a8c83e7 to
4ee148f
Compare
walldiss
reviewed
Aug 15, 2024
share/new_eds/testing.go
Outdated
| func testEDSes(t *testing.T, size int) map[string]*rsmt2d.ExtendedDataSquare { | ||
| fullEDS := edstest.RandEDS(t, size) | ||
|
|
||
| padding := rand.IntN(size * size) |
There was a problem hiding this comment.
Should be at least 1 padding share
| for i := range shares { | ||
| shares[i] = axsData[i*shrLn : (i+1)*shrLn] | ||
| if i > shrsRead-1 { |
There was a problem hiding this comment.
Just curious, where is -1 comes from?
There was a problem hiding this comment.
number of read shares starts from 1, while i from 0, so shrsRead has to be shifted
Comment on lines
+109
to
+112
| if share.GetNamespace(shr).Equals(share.TailPaddingNamespace) { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Need test for ods file to ensure file store was actually trimmed
Wondertan
force-pushed
the
shwap-trim
branch
2 times, most recently
from
37648e7 to
2e27c60
Compare
walldiss
approved these changes
Aug 15, 2024
Besides it parrallelizes the test to run them quicker
Implements tail padding share trimming a.k.a. compression with supporting changes. The actual trimming logic turned out extremely simple and does not even require any form of indexing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements tail padding share trimming a.k.a. compression with supporting changes. The actual trimming logic turned out extremely simple and does not even require any form of indexing. (896bdd3)
This PR is reviewable commit-by-commit and is supposed to merge as so.
Depends on #3643