New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shwap): Improve eds store cache refcounter forgot Close() protection #3638

Merged

walldiss merged 1 commit into celestiaorg:shwap from walldiss:fix-store-cache

Aug 8, 2024

Member

walldiss commented Aug 8, 2024

Force close Accessor if not closed within timeout
Close Accessor and log Error if ref was removed by GC instead of user
close Accessor on has check hitting the cache


          force close accessor on timeout

338eee1

walldiss added kind:feat shwap labels

walldiss self-assigned this

walldiss requested review from renaynay, Wondertan, vgonkivs, distractedm1nd, ramin and cristaloleg as code owners

August 8, 2024 15:01

Wondertan approved these changes

View reviewed changes

Member

Wondertan left a comment

LGTM but would port the refCloser part and force closing to main as well

walldiss merged commit 36bb8e6 into celestiaorg:shwap

16 of 20 checks passed

walldiss deleted the fix-store-cache branch

August 8, 2024 16:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Wondertan Wondertan approved these changes

renaynay Awaiting requested review from renaynay

vgonkivs Awaiting requested review from vgonkivs

distractedm1nd Awaiting requested review from distractedm1nd

ramin Awaiting requested review from ramin

cristaloleg Awaiting requested review from cristaloleg

Labels

kind:feat shwap