fix(store): use symlinks for empty blocks heighs #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
cristaloleg
as code owners
walldiss
force-pushed
the
use-symlinks-for-emptyheigh
branch
from
98b5ab2 to
c711d65
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shwap #3747 +/- ##
========================================
Coverage ? 46.91%
========================================
Files ? 314
Lines ? 17867
Branches ? 0
========================================
Hits ? 8383
Misses ? 8476
Partials ? 1008 ☔ View full report in Codecov by Sentry. |
Wondertan
reviewed
Sep 18, 2024
store/store.go
Outdated
| @@ -170,11 +170,18 @@ func (s *Store) createFile( | |||
| return false, nil | |||
| } | |||
|
|
|||
| func (s *Store) linkHeight(datahash share.DataHash, height uint64) error { | |||
There was a problem hiding this comment.
What about keeping this method usage as is, but change it to check for empty root inside and make needed link accordingly with proper comment. In other words, decision on whether its symlink or hardlink stays an impl detail of linkHeight method
walldiss
force-pushed
the
use-symlinks-for-emptyheigh
branch
from
c711d65 to
de00998
Compare
Wondertan
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is limitation on max amount of hard links in ext4 filesystem of 65000. Some chains have more empty blocks (arabica). We will use symlinks for empty blocks to avoid this limitation, while keeping hard-links for non-empty blocks.