feat(nodebuilder/da): implement go-da v0.6.1 changes #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
2 times, most recently
from
269c6e8 to
9332823
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3750 +/- ##
==========================================
+ Coverage 44.83% 46.49% +1.65%
==========================================
Files 265 314 +49
Lines 14620 18120 +3500
==========================================
+ Hits 6555 8425 +1870
- Misses 7313 8681 +1368
- Partials 752 1014 +262 ☔ View full report in Codecov by Sentry. |
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
c835b77 to
616465f
Compare
tzdybal
changed the title
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
616465f to
8a4573d
Compare
tzdybal
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
cristaloleg
as code owners
cristaloleg
reviewed
Sep 20, 2024
11 tasks
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
8a4573d to
8d8dc56
Compare
renaynay
reviewed
Sep 23, 2024
walldiss
reviewed
Sep 23, 2024
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
8d8dc56 to
4fe47ba
Compare
walldiss
reviewed
Sep 25, 2024
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
d5e9314 to
ad9e636
Compare
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
ad9e636 to
2ba5c18
Compare
renaynay
previously approved these changes
Sep 30, 2024
cristaloleg
approved these changes
Sep 30, 2024
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
13ab9e2 to
cb90ad5
Compare
renaynay
approved these changes
Sep 30, 2024
auto-merge was automatically disabled
October 2, 2024 14:42
Head branch was pushed to by a user without write access
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
048e823 to
d3536d4
Compare
This change ensures that if the options byte slice is empty, the parseOptions function returns an empty slice of ConfigOption without proceeding to unmarshal. This prevents potential errors and enhances the function's robustness.
…st loop The reassignment of 'tt' within the loop is unnecessary and redundant. This cleanup simplifies the code and reduces potential confusion during code reviews.
Unskip DA tests in `da_test.go` and correct parameter usage in test functions to ensure accurate comparisons. This allows the full test suite to run and verifies the integrity of the Data Availability logic.
Introduced tests for the SubmitWithOptions method to ensure correct behavior with valid and invalid input. These tests validate the API's handling of well-formed requests and error scenarios, improving the robustness of the DA client.
Anonymous struct used for parsing submit options was extracted as exported struct for better visibility and documentation.
Standardize the JSON keys in the `SubmitOptions` struct to follow snake_case convention. This change ensures consistency in JSON serialization and deserialization across all service methods and tests.
Upgraded the go-da dependency from v0.7.0 to v0.8.0 in go.mod and go.sum.
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
446cb55 to
2bed37a
Compare
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
Congrats @tzdybal ☝️ 😂 |
mojtaba-esk
pushed a commit
to vgonkivs/celestia-node
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3743