fix(header): soft failure is only for not enough voting power #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
walldiss
approved these changes
Sep 24, 2024
Wondertan
approved these changes
Sep 24, 2024
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 25, 2024
…iaorg#3769) (cherry picked from commit 7eca603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should set
libhead.VerifyError.SoftFailureto true only when error iscore.ErrNotEnoughVotingPowerSigned. In other words, this PR fixes a bug when we treat double vote and invalid signature as a soft failure (when it's not).CC: @vgonkivs @Wondertan