-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cel-shed/p2p): bootstrapper probe tool #3780
feat(cel-shed/p2p): bootstrapper probe tool #3780
Conversation
Signed-off-by: Smuu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3780 +/- ##
==========================================
+ Coverage 44.83% 46.46% +1.62%
==========================================
Files 265 314 +49
Lines 14620 18093 +3473
==========================================
+ Hits 6555 8407 +1852
- Misses 7313 8669 +1356
- Partials 752 1017 +265 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Smuu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning up and improving that PR!
- Linter seems to complain
- Did you test new flags work as expected?
Signed-off-by: Smuu <[email protected]>
I tried the arguments manually with these scenarios.
Do you see a way to write tests for these? |
Signed-off-by: Smuu <[email protected]>
We don't write tests for cel-shed usually. In some way it's bad, but on the bright side it saves a lot of time, like in this case writing a proper test is not straightforward. Usually, manual testing is enough here and that's why I am checking. |
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Head branch was pushed to by a user without write access
Fixed due to @tty47 |
Signed-off-by: Smuu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utack
Head branch was pushed to by a user without write access
6eeb8a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utack
Signed-off-by: Smuu <[email protected]> Co-authored-by: Hlib Kanunnikov <[email protected]>
Based on @Wondertan PR: #3511
This PR introduces a new
connect-bootstrappers
command to thecel-shed
tool. The command allows users to connect to bootstrappers of a specified network. It includes options to handle connection failures by returning errors if at least one or all bootstrappers are unreachable.This will be used by the @celestiaorg/devops team to create alerts if no Bootstrapper is reachable.
Closes #3511