Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share/ipld): use bits.Len64 instead of math.Log2 in newProofCollector #3867

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

notlelouch
Copy link
Contributor

closes #3852

@github-actions github-actions bot added the external Issues created by non node team members label Oct 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.25%. Comparing base (2469e7a) to head (3fd1913).
Report is 353 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3867      +/-   ##
==========================================
+ Coverage   44.83%   45.25%   +0.41%     
==========================================
  Files         265      314      +49     
  Lines       14620    21905    +7285     
==========================================
+ Hits         6555     9913    +3358     
- Misses       7313    10962    +3649     
- Partials      752     1030     +278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cristaloleg cristaloleg added the kind:fix Attached to bug-fixing PRs label Oct 22, 2024
@cristaloleg cristaloleg changed the title used bits.lens instead of math.log2 in newProofCollector fix(share/ipld): use bits.Len64 instead of math.Log2 in newProofCollector Oct 22, 2024
@Wondertan Wondertan merged commit 1ed2b82 into celestiaorg:main Oct 22, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

share/ipld: newProofCollector should use bits.Len instead of math.Log2 just in case
5 participants