Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump go-header and go-fraud #43

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Sep 1, 2023

Bumps to breaking versions of go-header and go-fraud, which now require ExtendedHeader to comply with the Header interface fully, thus the changes.

Is there an instruction on how to run tests here? I see some docker issues and don't see any dockerfile in the root.

@Wondertan
Copy link
Member Author

The markdown lint failure doesn't seem to be related

@tuxcanfly
Copy link
Contributor

@Wondertan The test suite pulls local-celestia-devnet docker image and runs integration tests against it using dockertest pkg. Standard go test command works, but expects docker service to be up. Markdown lint issue should be fixed in #50

Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@Manav-Aggarwal Manav-Aggarwal added this pull request to the merge queue Sep 12, 2023
Merged via the queue into celestiaorg:main with commit 0e7b3e1 Sep 12, 2023
10 checks passed
@Wondertan Wondertan deleted the bump-go-header branch September 12, 2023 14:58
github-merge-queue bot pushed a commit to rollkit/rollkit that referenced this pull request Sep 13, 2023
Manav-Aggarwal added a commit to rollkit/rollkit that referenced this pull request Sep 13, 2023
gupadhyaya pushed a commit to rollkit/rollkit that referenced this pull request Sep 13, 2023
chandiniv1 pushed a commit to chandiniv1/rollkit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants