Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add vesting module changes to staking module #206

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Jun 22, 2022

Description

add the necessary change to the staking module required by the vesting module. WIP

Closes: #XXXX

- Use proper sdkerrors where appropriate.
- Use correct test helpers for checking errors.
- Implement a new redelegation iterator and use it in read-only
  cases.
@evan-forbes evan-forbes added the C: app Changes related to the celestia-app branches label Jun 22, 2022
@evan-forbes evan-forbes self-assigned this Jun 22, 2022
@evan-forbes evan-forbes changed the title Evan/add vesting module changes to staking module chore: add vesting module changes to staking module Jun 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #206 (219d780) into evan/celestia-ize-v046.0-rc1 (bf31baa) will decrease coverage by 0.51%.
The diff coverage is 84.56%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           evan/celestia-ize-v046.0-rc1     #206      +/-   ##
================================================================
- Coverage                         66.65%   66.14%   -0.52%     
================================================================
  Files                               749      671      -78     
  Lines                             77383    71137    -6246     
================================================================
- Hits                              51578    47051    -4527     
+ Misses                            22709    21419    -1290     
+ Partials                           3096     2667     -429     
Impacted Files Coverage Δ
x/staking/keeper/delegation.go 76.47% <84.56%> (+3.21%) ⬆️
orm/model/ormtable/paginate.go
cosmovisor/args.go
orm/model/ormtable/singleton.go
container/container.go
orm/model/ormtable/auto_increment.go
container/option.go
orm/encoding/ormfield/codec.go
orm/encoding/ormfield/int32.go
orm/encoding/ormkv/entry.go
... and 72 more

@evan-forbes
Copy link
Member Author

can close since we're planning on using the standard vesting module now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: app Changes related to the celestia-app branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants