forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add fraudproof verification on a store level #254
Closed
Manav-Aggarwal
wants to merge
10
commits into
manav/single-round-fraudproof
from
manav/add-store-level-fp-verification
Closed
feat: Add fraudproof verification on a store level #254
Manav-Aggarwal
wants to merge
10
commits into
manav/single-round-fraudproof
from
manav/add-store-level-fp-verification
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manav-Aggarwal
added
C: Cevmos
Changes related to the cevmos branches
block-fraud-proofs
Block Fraud Proofs (Generation and verification)
labels
Aug 9, 2022
Manav-Aggarwal
force-pushed
the
manav/add-store-level-fp-verification
branch
from
August 9, 2022 07:50
ac5f8da
to
de2f0b8
Compare
This was referenced Aug 9, 2022
Manav-Aggarwal
force-pushed
the
manav/add-store-level-fp-verification
branch
2 times, most recently
from
August 10, 2022 22:25
2376acd
to
7436242
Compare
Manav-Aggarwal
changed the base branch from
v0.46.0-with-smt
to
manav/single-round-fraudproof
August 11, 2022 17:08
Manav-Aggarwal
force-pushed
the
manav/single-round-fraudproof
branch
from
August 12, 2022 01:54
295f199
to
266a4de
Compare
Manav-Aggarwal
force-pushed
the
manav/add-store-level-fp-verification
branch
from
August 12, 2022 01:56
b2af66b
to
78022b8
Compare
jbowen93
approved these changes
Aug 16, 2022
Manav-Aggarwal
force-pushed
the
manav/single-round-fraudproof
branch
from
August 16, 2022 19:58
266a4de
to
c088b81
Compare
Manav-Aggarwal
force-pushed
the
manav/add-store-level-fp-verification
branch
from
August 16, 2022 19:58
30f5065
to
3c5cd63
Compare
everything is moved to cosmos-sdk-rollmint repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
block-fraud-proofs
Block Fraud Proofs (Generation and verification)
C: Cevmos
Changes related to the cevmos branches
C:Store
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a fraudproof is received by an optimint full node, it should first verify the fraudproof by doing a cross-reference of header app hash retrieved from the DA layer against inclusion proofs in the fraudproof on a store level.
Parts covered from the cycle of a fraudproof:
This PR simulates this check in the baseapp module
Parent issue: #253
Builds on top of: #248
Closes: #253
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change