Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add fraudproof verification on a store level #254

Conversation

Manav-Aggarwal
Copy link
Member

@Manav-Aggarwal Manav-Aggarwal commented Aug 9, 2022

Description

When a fraudproof is received by an optimint full node, it should first verify the fraudproof by doing a cross-reference of header app hash retrieved from the DA layer against inclusion proofs in the fraudproof on a store level.

Parts covered from the cycle of a fraudproof:

Optimint Full/Light Node (Verifier of fraudproof)
2. It verifies the fraudproof by doing a cross-reference of a header app hash from the blockchain against the contents of a fraudproof

This PR simulates this check in the baseapp module

Parent issue: #253

Builds on top of: #248

Closes: #253


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@Manav-Aggarwal Manav-Aggarwal requested a review from jbowen93 August 9, 2022 06:22
@Manav-Aggarwal Manav-Aggarwal self-assigned this Aug 9, 2022
@Manav-Aggarwal Manav-Aggarwal added C: Cevmos Changes related to the cevmos branches block-fraud-proofs Block Fraud Proofs (Generation and verification) labels Aug 9, 2022
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/add-store-level-fp-verification branch from ac5f8da to de2f0b8 Compare August 9, 2022 07:50
@Manav-Aggarwal Manav-Aggarwal linked an issue Aug 9, 2022 that may be closed by this pull request
@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review August 9, 2022 07:59
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/add-store-level-fp-verification branch 2 times, most recently from 2376acd to 7436242 Compare August 10, 2022 22:25
@Manav-Aggarwal Manav-Aggarwal changed the base branch from v0.46.0-with-smt to manav/single-round-fraudproof August 11, 2022 17:08
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/single-round-fraudproof branch from 295f199 to 266a4de Compare August 12, 2022 01:54
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/add-store-level-fp-verification branch from b2af66b to 78022b8 Compare August 12, 2022 01:56
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/single-round-fraudproof branch from 266a4de to c088b81 Compare August 16, 2022 19:58
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/add-store-level-fp-verification branch from 30f5065 to 3c5cd63 Compare August 16, 2022 19:58
@Manav-Aggarwal
Copy link
Member Author

everything is moved to cosmos-sdk-rollmint repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-fraud-proofs Block Fraud Proofs (Generation and verification) C: Cevmos Changes related to the cevmos branches C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fraudproof verification on a store level
2 participants