-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set proposer-based rewards to 0 #309
feat: set proposer-based rewards to 0 #309
Conversation
It seems a little silly that it's easier to override default params like this in our fork of Cosmos SDK rather than in the app repo but it appears common per this search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks for the info. Its only the defaults anyway
Codecov Report
@@ Coverage Diff @@
## release/v0.46.x-celestia #309 +/- ##
============================================================
- Coverage 65.69% 65.52% -0.17%
============================================================
Files 679 666 -13
Lines 72212 70980 -1232
============================================================
- Hits 47439 46512 -927
+ Misses 22108 21891 -217
+ Partials 2665 2577 -88
|
BaseProposerReward: sdk.ZeroDec(), // deprecated | ||
BonusProposerReward: sdk.ZeroDec(), // deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected that these two can simply be deleted as we do not need to be backwards compatible at all. But I guess for the sake of minimal changes to the upstream SDK, this is the more reasonable approach still.
Q: These would still be changeable via governance though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These would still be changeable via governance though?
yes, this is only changing the defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can delete the params if that's preferred. I set the params to zero b/c the PR in the description above and the issue @liamsi created:
In case we launch with 0.46, we should set the param to 0
Will merge this as-is b/c I don't see any blocking feedback. |
Closes celestiaorg/celestia-app#1589
I briefly considered overriding these params in celestia-app similar to what we do for the gov module here but that's a messier diff and the diff introduced in this PR won't be difficult to resolve b/c upstream has deprecated these pararms in cosmos#12876. Tests in this PR were updated based on cosmos#12876.
Note: no Mainnet milestone exists in this repo but this is needed for Mainnet.